Impala Public Jenkins has submitted this change and it was merged. Change subject: IMPALA-5553: Fix expr-test in release builds ......................................................................
IMPALA-5553: Fix expr-test in release builds expr-test fails in release build as it uses Literal::CreateLiteral() to create literal expressions. Literal::CreateLiteral() wraps ParseString() with DCHECK() so it becomes a no-op in release builds. This change fixes the issue by moving Literal::CreateLiteral() from literal.cc to expr-test.cc as it's only used by the test code. Also replaces DCHECK() wrapped around ParseString() with EXPECT_TRUE(). Verified the fix by building and running a release build of expr-test. Change-Id: Id1257da350cb6cb69886e93f6615cdadd17c187d Reviewed-on: http://gerrit.cloudera.org:8080/7255 Reviewed-by: Tim Armstrong <tarmstr...@cloudera.com> Tested-by: Impala Public Jenkins --- M be/src/exprs/expr-test.cc M be/src/exprs/literal.cc M be/src/exprs/literal.h 3 files changed, 114 insertions(+), 102 deletions(-) Approvals: Impala Public Jenkins: Verified Tim Armstrong: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/7255 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id1257da350cb6cb69886e93f6615cdadd17c187d Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Michael Ho <k...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com>
