Tim Armstrong has posted comments on this change. Change subject: More GCC 7 fixes ......................................................................
Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/7220/3/source/cyrus-sasl/build.sh File source/cyrus-sasl/build.sh: Line 48: # -fgnu89-inline: work around linker error with multiple definitions of libc functions. > So -fgnu89-inline is more permissive? The online documentation I found for It just has slightly different semantics - without the flag some of these functions get emitted into the object file with a linkage that disallows multiple definitions. With the flag the functions either aren't emitted or are emitted with something like "linkonce" linkage. -- To view, visit http://gerrit.cloudera.org:8080/7220 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibeaac85be762487de27019c2dac018d64e80f587 Gerrit-PatchSet: 3 Gerrit-Project: native-toolchain Gerrit-Branch: master Gerrit-Owner: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Jim Apple <jbapple-imp...@apache.org> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-HasComments: Yes
