Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-5431: Remove redundant path exists checks during table load ......................................................................
Patch Set 6: Code-Review+2 (3 comments) http://gerrit.cloudera.org:8080/#/c/7095/5/fe/src/main/java/org/apache/impala/catalog/HdfsTable.java File fe/src/main/java/org/apache/impala/catalog/HdfsTable.java: PS5, Line 302: Reference<Long> numUnknownDiskIds = new Reference<Long>(Long.valueOf(0)); nit: move it below L305. If we're going to return there is no need to get a new Reference. PS5, Line 727: new ArrayList<FileDescriptor>() newFileDescs? http://gerrit.cloudera.org:8080/#/c/7095/5/fe/src/main/java/org/apache/impala/common/FileSystemUtil.java File fe/src/main/java/org/apache/impala/common/FileSystemUtil.java: Line 498: } catch (FileNotFoundException e) { I am thinking maybe add a warn in the log that the path doesn't exist. -- To view, visit http://gerrit.cloudera.org:8080/7095 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id10ecf64ea2eda2d0f9299c0aa371933eca22281 Gerrit-PatchSet: 6 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Bharath Vissapragada <bhara...@cloudera.com> Gerrit-Reviewer: Alex Behm <alex.b...@cloudera.com> Gerrit-Reviewer: Bharath Vissapragada <bhara...@cloudera.com> Gerrit-Reviewer: Dimitris Tsirogiannis <dtsirogian...@cloudera.com> Gerrit-HasComments: Yes
