Alex Behm has posted comments on this change. Change subject: IMPALA-5500: Reduce catalog update topic size ......................................................................
Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/7268/4/be/src/catalog/catalog-server.cc File be/src/catalog/catalog-server.cc: Line 328: Status status = thrift_serializer_.Serialize(&catalog_object, &serialized_object); Let's try to avoid the extra copy for the !FLAGS_compact_catalog_topic case. I think you could pass in &item.value to Serialize like before, and then change CompressCatalogObject() to take a const uint8_t* and a length as input. -- To view, visit http://gerrit.cloudera.org:8080/7268 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2f725cd8596205e6101d5b56abf08125faa30b0a Gerrit-PatchSet: 4 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Dimitris Tsirogiannis <dtsirogian...@cloudera.com> Gerrit-Reviewer: Alex Behm <alex.b...@cloudera.com> Gerrit-Reviewer: Dimitris Tsirogiannis <dtsirogian...@cloudera.com> Gerrit-HasComments: Yes
