Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-5500: Reduce catalog update topic size ......................................................................
Patch Set 7: (2 comments) http://gerrit.cloudera.org:8080/#/c/7268/7/be/src/catalog/catalog-server.cc File be/src/catalog/catalog-server.cc: Line 335: pending_topic_updates_.pop_back(); > I think we could incorrectly end up popping two pending topic updates here. Good catch. Done http://gerrit.cloudera.org:8080/#/c/7268/7/be/src/catalog/catalog-util.cc File be/src/catalog/catalog-util.cc: Line 202: ReadWriteUtil::PutInt(output_buffer_ptr, (uint32_t)catalog_object->size()); > static_cast instead of C-style cast Done -- To view, visit http://gerrit.cloudera.org:8080/7268 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2f725cd8596205e6101d5b56abf08125faa30b0a Gerrit-PatchSet: 7 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Dimitris Tsirogiannis <dtsirogian...@cloudera.com> Gerrit-Reviewer: Alex Behm <alex.b...@cloudera.com> Gerrit-Reviewer: Dimitris Tsirogiannis <dtsirogian...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-HasComments: Yes
