Tim Armstrong has posted comments on this change. Change subject: IMPALA-5560: always store CHAR(N) inline in tuple ......................................................................
Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/7303/2/be/src/exec/hash-table.cc File be/src/exec/hash-table.cc: PS2, Line 72: 128 bytes > update Done http://gerrit.cloudera.org:8080/#/c/7303/2/be/src/exec/parquet-column-readers.cc File be/src/exec/parquet-column-readers.cc: PS2, Line 571: StringValue sv > what's the point of this StringValue now? This seems confusing and round ab Done. Also fixed the dst type weirdness - that was actually an easy fix, unlike the other place that does the same weird thing. -- To view, visit http://gerrit.cloudera.org:8080/7303 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9c0b823ccff6b0c37f5267c548d096c29b8caac3 Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com> Gerrit-Reviewer: Matthew Jacobs <m...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-HasComments: Yes
