Lars Volker has posted comments on this change. Change subject: IMPALA-5427: Fix race between CRS::UpdateQueryStatus() and beeswax RPCs ......................................................................
Patch Set 12: Code-Review+2 (2 comments) Thank for the review. I addressed the last comments, carrying Dan's +2. http://gerrit.cloudera.org:8080/#/c/7155/11/be/src/service/impala-beeswax-server.cc File be/src/service/impala-beeswax-server.cc: Line 255: !request_state->query_status().ok()); > any reason not to make this stronger and have the implication go in both di Done Line 293: !request_state->query_status().ok()); > same Done -- To view, visit http://gerrit.cloudera.org:8080/7155 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib4494fe3f933cc23841db0e7da407eec5650f2b5 Gerrit-PatchSet: 12 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Lars Volker <l...@cloudera.com> Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com> Gerrit-Reviewer: Lars Volker <l...@cloudera.com> Gerrit-Reviewer: Sailesh Mukil <sail...@cloudera.com> Gerrit-HasComments: Yes