Thomas Tauber-Marshall has uploaded a new change for review. http://gerrit.cloudera.org:8080/7346
Change subject: IMPALA-5611: KuduPartitionExpr holds onto memory unnecessarily ...................................................................... IMPALA-5611: KuduPartitionExpr holds onto memory unnecessarily IMPALA-3742 introduced KuduPartitionExpr, which takes a row and passes it to the Kudu client to determine what partitionit belongs to. KuduPartitionExpr never calls ScalarExprEvaluator::FreeLocalAllocations, causing it to hang on to memory longer than it needs it. Since we only need the value of the row for the call into the Kudu client, we can call FreeLocalAllocations after that. Testing: - Manually verified that large Kudu inserts with string columns can pass with much lower mem limits now. Change-Id: Ia661eb8bed114070728a1497ccf7ed6893237e5e --- M be/src/exprs/kudu-partition-expr.cc 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/46/7346/1 -- To view, visit http://gerrit.cloudera.org:8080/7346 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ia661eb8bed114070728a1497ccf7ed6893237e5e Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Thomas Tauber-Marshall <tmarsh...@cloudera.com>
