Alex Behm has posted comments on this change. Change subject: IMPALA-5036: Parquet count star optimization ......................................................................
Patch Set 7: (6 comments) http://gerrit.cloudera.org:8080/#/c/6812/7/fe/src/main/java/org/apache/impala/planner/HdfsScanNode.java File fe/src/main/java/org/apache/impala/planner/HdfsScanNode.java: Line 277: private boolean checkParquetCountStarOptimization(Analyzer analyzer, canApplyParquetCountStarOptimization() Line 281: if (!aggInfo_.hasCountStarOnly()) return false; combine with previous check on agg info Line 282: if (fileFormats.size() != 1) return false; move the PARQUET check here as well http://gerrit.cloudera.org:8080/#/c/6812/7/fe/src/main/java/org/apache/impala/planner/SingleNodePlanner.java File fe/src/main/java/org/apache/impala/planner/SingleNodePlanner.java: Line 1193: * If the state of 'hdfsTblRef' and 'aggInfo' permits this, the slots may be produced I think we can phrase this more generically now, something like: The given 'aggInfo' is used for detecting and applying optimizations that span both the scan and aggregation. Line 1260: * 'aggInfo' is used for determining whether to try to produce the slots with metadata I think we can phrase this more generically now, something like: The given 'aggInfo' is used for detecting and applying optimizations that span both the scan and aggregation. Only applicable to HDFS table refs. Line 1503: * 'aggInfo' is used for determining whether to try to produce the slots with metadata I think we can phrase this more generically now, something like: The given 'aggInfo' is used for detecting and applying optimizations that span both the scan and aggregation. Only applicable to HDFS table refs. -- To view, visit http://gerrit.cloudera.org:8080/6812 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I536b85c014821296aed68a0c68faadae96005e62 Gerrit-PatchSet: 7 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Taras Bobrovytsky <tbobrovyt...@cloudera.com> Gerrit-Reviewer: Alex Behm <alex.b...@cloudera.com> Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com> Gerrit-Reviewer: Lars Volker <l...@cloudera.com> Gerrit-Reviewer: Marcel Kornacker <mar...@cloudera.com> Gerrit-Reviewer: Mostafa Mokhtar <mmokh...@cloudera.com> Gerrit-Reviewer: Taras Bobrovytsky <tbobrovyt...@cloudera.com> Gerrit-Reviewer: Zach Amsden <zams...@cloudera.com> Gerrit-HasComments: Yes
