Dan Hecht has posted comments on this change. Change subject: IMPALA-5611: KuduPartitionExpr holds onto memory unnecessarily ......................................................................
Patch Set 4: Code-Review+2 (1 comment) Please see if Michael wants to look also. http://gerrit.cloudera.org:8080/#/c/7346/4/be/src/runtime/data-stream-sender.cc File be/src/runtime/data-stream-sender.cc: Line 482: COUNTER_ADD(total_sent_rows_counter_, batch->num_rows()); this is fine, but any reason to not just hoist it from the if-stmt to here, which is the pattern we usually use (adjacent with CheckQueryState(), which also has to happen after evaluating udfs)? -- To view, visit http://gerrit.cloudera.org:8080/7346 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia661eb8bed114070728a1497ccf7ed6893237e5e Gerrit-PatchSet: 4 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Thomas Tauber-Marshall <tmarsh...@cloudera.com> Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com> Gerrit-Reviewer: Matthew Jacobs <m...@cloudera.com> Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Thomas Tauber-Marshall <tmarsh...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-HasComments: Yes
