Matthew Jacobs has uploaded a new change for review. http://gerrit.cloudera.org:8080/7371
Change subject: IMPALA-5623: Fix lag() on STRING cols to release UDF mem ...................................................................... IMPALA-5623: Fix lag() on STRING cols to release UDF mem IMPALA-4120 fixed an issue where lead/lag was potentially operating on memory that the UDA didn't own, resulting in potentially wrong results. As part of that fix, lead and lag started allocating 'global' UDF memory (e.g. via Allocate() rather than AllocateLocal()) in Init() which needs to be freed in Serialize() or Finalize(), but only lead() was updated to free the memory. This memory is eventually freed when the fragment is torn down, but as a result of not freeing the memory in Serialize or Finalize, the memory may be allocated longer than necessary. Change-Id: Id2b69b4ccb9cac076abca19bed6f0b1dd11dfff3 --- M fe/src/main/java/org/apache/impala/catalog/BuiltinsDb.java M testdata/workloads/functional-query/queries/QueryTest/analytic-fns.test 2 files changed, 17 insertions(+), 1 deletion(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/71/7371/1 -- To view, visit http://gerrit.cloudera.org:8080/7371 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Id2b69b4ccb9cac076abca19bed6f0b1dd11dfff3 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Matthew Jacobs <m...@cloudera.com>
