Impala Public Jenkins has submitted this change and it was merged. Change subject: IMPALA-5031: Set DiskIoMgr::ScanRange::is_cancelled_ before read ......................................................................
IMPALA-5031: Set DiskIoMgr::ScanRange::is_cancelled_ before read Reading a uninitialized memory as a boolean is undefined behavior when it isn't the bit pattern for true or false. Clang's undefined behavior sanitizer caught is_cancelled_ being used before being initialized; this patch also initializes the other booleans in DiskIoMgr::ScanRange to prevent similar undefined behavior. Change-Id: I22898ec96ac44c4902f8072f27453cfc58358cae Reviewed-on: http://gerrit.cloudera.org:8080/7294 Reviewed-by: Jim Apple <jbapple-imp...@apache.org> Tested-by: Impala Public Jenkins --- M be/src/runtime/disk-io-mgr-scan-range.cc M be/src/runtime/disk-io-mgr.h 2 files changed, 6 insertions(+), 8 deletions(-) Approvals: Impala Public Jenkins: Verified Jim Apple: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/7294 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: I22898ec96ac44c4902f8072f27453cfc58358cae Gerrit-PatchSet: 6 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Jim Apple <jbapple-imp...@apache.org> Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Jim Apple <jbapple-imp...@apache.org> Gerrit-Reviewer: Michael Ho <k...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com>
