Henry Robinson has posted comments on this change. Change subject: IMPALA-4925: Cancel finstance if query has finished ......................................................................
Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/5987/2/tests/query_test/test_lifecycle.py File tests/query_test/test_lifecycle.py: Line 94: assert end - now < 120, "Query took too long to complete: " + duration + "s" > It seems like we could probably set this even lower, but this seems fine. Agree it's a bit conservative, but I wanted to make sure ASAN builds didn't trigger any false positives. -- To view, visit http://gerrit.cloudera.org:8080/5987 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I59f45e64978c9ab9914b5c33e86009960b4a88c4 Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Henry Robinson <he...@cloudera.com> Gerrit-Reviewer: Henry Robinson <he...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-HasComments: Yes
