anujphadke has posted comments on this change. Change subject: IMPALA-5586: Null-aware anti-join can take a long time to cancel ......................................................................
Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c/7393/3/be/src/exec/partitioned-hash-join-node.cc File be/src/exec/partitioned-hash-join-node.cc: Line 1018: // For each row, iterate over all rows in the build table. > The need for RETURN_IF_CANCELLED is a little subtle. A one-line comment wou Done Line 1023: // This loop may run for a long time. Periodically check for cancellation. > This loop can also potentially run for a long time if build_rows is large. Done -- To view, visit http://gerrit.cloudera.org:8080/7393 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0800754d4ad31cbadbdfadc630c640963f3f6053 Gerrit-PatchSet: 4 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: anujphadke <apha...@cloudera.com> Gerrit-Reviewer: Thomas Tauber-Marshall <tmarsh...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: anujphadke <apha...@cloudera.com> Gerrit-HasComments: Yes
