Sailesh Mukil has posted comments on this change. Change subject: IMPALA-5275: Avoid printing status stack trace on hot paths ......................................................................
Patch Set 1: (2 comments) This should be a good improvement! Just have a couple of comments. http://gerrit.cloudera.org:8080/#/c/7449/1/be/src/service/impala-server.cc File be/src/service/impala-server.cc: PS1, Line 664: TExecSummary exec_summary; All the data would be copied over if you're not using a reference. Ideally you'd want this to be a const ref, however, you can't leave a const ref uninitialized. So why not have the 'query_record' iterator in the outer scope here and get rid of these new local variables you created. PS1, Line 680: *result = exec_summary; This is pointing to a local stack variable, which will be an invalid reference after the function returns. -- To view, visit http://gerrit.cloudera.org:8080/7449 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ief083f558fba587381aa7fe8f99da279da02f1f2 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Bikramjeet Vig <bikramjeet....@cloudera.com> Gerrit-Reviewer: Matthew Jacobs <m...@cloudera.com> Gerrit-Reviewer: Sailesh Mukil <sail...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-HasComments: Yes
