Michael Ho has posted comments on this change. Change subject: IMPALA-5670: Misc. tidying of ExecEnv ......................................................................
Patch Set 3: (3 comments) Thanks for cleaning things up. Looks much better. http://gerrit.cloudera.org:8080/#/c/7445/3/be/src/testutil/in-process-servers.h File be/src/testutil/in-process-servers.h: PS3, Line 62: bool use_statestore remove http://gerrit.cloudera.org:8080/#/c/7445/3/be/src/testutil/mini-impala-cluster.cc File be/src/testutil/mini-impala-cluster.cc: PS3, Line 41: DECLARE_string(principal); Not used ? PS3, Line 81: FLAGS_use_statestore) Missing removal ? -- To view, visit http://gerrit.cloudera.org:8080/7445 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3886bc0edfae0c65c302e1a1812632e60668cd4c Gerrit-PatchSet: 3 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Henry Robinson <he...@cloudera.com> Gerrit-Reviewer: Henry Robinson <he...@cloudera.com> Gerrit-Reviewer: Michael Ho <k...@cloudera.com> Gerrit-Reviewer: Sailesh Mukil <sail...@cloudera.com> Gerrit-HasComments: Yes
