Hello Impala Public Jenkins, Matthew Jacobs, I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/7450 to look at the new patch set (#4). Change subject: IMPALA-5529: Add additional function signatures for TRUNC() ...................................................................... IMPALA-5529: Add additional function signatures for TRUNC() The following signatures to be added: +--------------+----------------------------------+-------------+---------------+ | return type | signature | binary type | is persistent | +--------------+----------------------------------+-------------+---------------+ | DECIMAL(*,*) | trunc(DECIMAL(*,*)) | BUILTIN | true | | DECIMAL(*,*) | trunc(DECIMAL(*,*), BIGINT) | BUILTIN | true | | DECIMAL(*,*) | trunc(DECIMAL(*,*), INT) | BUILTIN | true | | DECIMAL(*,*) | trunc(DECIMAL(*,*), SMALLINT) | BUILTIN | true | | DECIMAL(*,*) | trunc(DECIMAL(*,*), TINYINT) | BUILTIN | true | | BIGINT | trunc(DOUBLE) | BUILTIN | true | +--------------+----------------------------------+-------------+---------------+ Tests: * Adds tests for the new builtin trunc()/dtrunc() Change-Id: I856da9f817b948de3c72af60a0742b128398b4cf --- M common/function-registry/impala_functions.py M fe/src/main/java/org/apache/impala/analysis/FunctionCallExpr.java M fe/src/test/java/org/apache/impala/analysis/AnalyzeExprsTest.java 3 files changed, 36 insertions(+), 19 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/50/7450/4 -- To view, visit http://gerrit.cloudera.org:8080/7450 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I856da9f817b948de3c72af60a0742b128398b4cf Gerrit-PatchSet: 4 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Kim Jin Chul <jinc...@gmail.com> Gerrit-Reviewer: Alex Behm <alex.b...@cloudera.com> Gerrit-Reviewer: Greg Rahn <gr...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Kim Jin Chul <jinc...@gmail.com> Gerrit-Reviewer: Matthew Jacobs <m...@cloudera.com> Gerrit-Reviewer: Thomas Tauber-Marshall <tmarsh...@cloudera.com>