Pooja Nilangekar has posted comments on this change. Change subject: Populate OffsetIndex and ColumnIndex of a row_group and Filter pages ......................................................................
Patch Set 3: (4 comments) http://gerrit.cloudera.org:8080/#/c/7465/2/be/src/exec/hdfs-parquet-scanner.cc File be/src/exec/hdfs-parquet-scanner.cc: Line 537: RETURN_IF_ERROR(scan_node_->runtime_state()->io_mgr()->AddScanRange( > A comment might help to understand why you abort altogether here. Why is it Done http://gerrit.cloudera.org:8080/#/c/7465/2/be/src/exec/parquet-index-filter.cc File be/src/exec/parquet-index-filter.cc: PS2, Line 203: : while (it != filtered_ranges.end()) { > These aren't needed anymore now, are they? Done http://gerrit.cloudera.org:8080/#/c/7465/2/be/src/exec/parquet-index-filter.h File be/src/exec/parquet-index-filter.h: PS2, Line 50: FilteredPageI > FilteredPageInfos may be more clear. Done http://gerrit.cloudera.org:8080/#/c/7465/2/tests/query_test/test_insert_parquet.py File tests/query_test/test_insert_parquet.py: Line 747: if valid: > No need to change it now, but this line has now ~10 levels of indent. :) Done. Changed the previous_valid check to continue if false. -- To view, visit http://gerrit.cloudera.org:8080/7465 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idace1e57067f95973cef3567eeb84f2ad87fd3f6 Gerrit-PatchSet: 3 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Pooja Nilangekar <pooja.nilange...@cloudera.com> Gerrit-Reviewer: Lars Volker <l...@cloudera.com> Gerrit-Reviewer: Pooja Nilangekar <pooja.nilange...@cloudera.com> Gerrit-HasComments: Yes