Vincent Tran has posted comments on this change. Change subject: IMPALA-5336: Fix partition pruning when column is cast ......................................................................
Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/7521/1/fe/src/main/java/org/apache/impala/planner/HdfsPartitionPruner.java File fe/src/main/java/org/apache/impala/planner/HdfsPartitionPruner.java: PS1, Line 185: if (bp.getChild(0).isImplicitCast()) return false; Will this also change the behaviour of implicitly casted integer types (e.g. BIGINT <op> INT)? One question that I didn't quite have an answer/explanation for while working on this was that this bug didn't seem to affect implicitly casted integer-type partition keys. -- To view, visit http://gerrit.cloudera.org:8080/7521 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I94f597a6589f5e34d2b74abcd29be77c4161cd99 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Matthew Jacobs <m...@cloudera.com> Gerrit-Reviewer: Sailesh Mukil <sail...@cloudera.com> Gerrit-Reviewer: Vincent Tran <vtt...@cloudera.com> Gerrit-HasComments: Yes
