Henry Robinson has posted comments on this change. Change subject: IMPALA-5394: Handle blocked HS2 connections ......................................................................
Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c/7061/4/be/src/service/impala-server.cc File be/src/service/impala-server.cc: PS4, Line 1963: exec_env->metrics(), FLAGS_fe_service_threads, ThriftServer::ThreadPool); > Running this change through run-all-tests and changing the comment at 1954 Yes, let's remove it for network-perf-benchmark.cc. PS4, Line 1985: Threaded > Does it matter that FLAG_enable_accept_queue_server can be turned to false I think the accept queue is stable enough at this point - it's been running in production for us for quite a long time. We can probably deprecate the flag (and hide it using DEFINE_bool_hidden). -- To view, visit http://gerrit.cloudera.org:8080/7061 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I56a5f3d9cf931cff14eae7f236fea018236a6255 Gerrit-PatchSet: 4 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: John Sherman <j...@arcadiadata.com> Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com> Gerrit-Reviewer: Henry Robinson <he...@cloudera.com> Gerrit-Reviewer: John Sherman <j...@arcadiadata.com> Gerrit-Reviewer: Matthew Jacobs <m...@cloudera.com> Gerrit-Reviewer: Sailesh Mukil <sail...@cloudera.com> Gerrit-HasComments: Yes
