Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5764: Allow overriding packaged components ......................................................................
Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/7581/1/bin/impala-config.sh File bin/impala-config.sh: PS1, Line 131: cdh > Keeping it as cdh_components kind-of makes sense to me as long as we're put I see, if that's the use case that makes sense. It might be helpful to have a comment indicating how you might also include X_components. -- To view, visit http://gerrit.cloudera.org:8080/7581 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I95c2662e6f62adc924cc5de7a371202126046545 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Zach Amsden <zams...@cloudera.com> Gerrit-Reviewer: David Knupp <dkn...@cloudera.com> Gerrit-Reviewer: Jim Apple <jbapple-imp...@apache.org> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Matthew Jacobs <m...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-HasComments: Yes
