Kim Jin Chul has posted comments on this change. Change subject: IMPALA-5116: Remove deprecated hash_* types in gutil ......................................................................
Patch Set 4: (2 comments) Sorry for the late. Let me answer Jim's comment soon. http://gerrit.cloudera.org:8080/#/c/7414/3/be/src/gutil/hash/hash.h File be/src/gutil/hash/hash.h: PS3, Line 96: using std::hash; : > What code requires this remain? I answered in the PS#4 Line 189: > What code requires that this section remain? I answered in the PS#4 -- To view, visit http://gerrit.cloudera.org:8080/7414 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I06af30fd15acd43a60e3c30af54056c96520b6e9 Gerrit-PatchSet: 4 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Kim Jin Chul <jinc...@gmail.com> Gerrit-Reviewer: Jim Apple <jbapple-imp...@apache.org> Gerrit-Reviewer: Kim Jin Chul <jinc...@gmail.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-HasComments: Yes