Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5787: Dropped status in KuduTableSink::Send() ......................................................................
Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/7667/1/be/src/exec/kudu-table-sink.cc File be/src/exec/kudu-table-sink.cc: PS1, Line 241: // This can only fail if we set a col to an incorrect type, which would be a bug in : // planning, so we can DCHECK. can you check with the kudu developers (e.g. on the Kudu dev slack channel) that this is also safe in the context of concurrent schema changes? I'm 95% confident that this is the case, but it'd be good to check. -- To view, visit http://gerrit.cloudera.org:8080/7667 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia228d98ca90de8638b0afcc242c788e225fb450f Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Thomas Tauber-Marshall <tmarsh...@cloudera.com> Gerrit-Reviewer: Matthew Jacobs <m...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-HasComments: Yes