Tim Armstrong has posted comments on this change. Change subject: IMPALA-5644,IMPALA-5810: Min reservation improvements ......................................................................
Patch Set 4: (3 comments) http://gerrit.cloudera.org:8080/#/c/7678/5/be/src/runtime/bufferpool/reservation-util.h File be/src/runtime/bufferpool/reservation-util.h: PS5, Line 32: allocated to buffer reservations, > I think it's the latter. That seems clearer. PS5, Line 36: : /// The limit on reservations is co > I think this is providing examples of things that use the memory that is le No there isn't a comment like that. I think this is the only place. I guess we should be a little careful with how we word it because it's subject to change. It might be worth referencing this JIRA IMPALA-4834 "All operators should operate within a memory constraint" since that will be driving conversion of things from buffer pool to non-buffer pool memory. http://gerrit.cloudera.org:8080/#/c/7678/4/be/src/scheduling/admission-controller.cc File be/src/scheduling/admission-controller.cc: PS4, Line 429: GetBufferReservationLimitFromMemLimit > This was actually my intention originally, and that's why I asked the quest Ah yeah, I think this should be an else-if. -- To view, visit http://gerrit.cloudera.org:8080/7678 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iabe87ce8f460356cfe4d1be4d7092c5900f9d79b Gerrit-PatchSet: 4 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Matthew Jacobs <m...@cloudera.com> Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com> Gerrit-Reviewer: Matthew Jacobs <m...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-HasComments: Yes
