Henry Robinson has posted comments on this change. Change subject: tidy: enable rule for constant naming ......................................................................
Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/7740/1//COMMIT_MSG Commit Message: Line 7: tidy: enable rule for constant naming the change is fine, but I don't think this message matches what was done. For example: the constant naming rule is not actually enabled in our .clang-tidy. Also, a reader of this message would think that the kFooBar pattern was Impala's constant naming scheme, and that it has been applied to the whole codebase. Can you clarify? -- To view, visit http://gerrit.cloudera.org:8080/7740 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7971659ef3152580d44d6ddfb18be7ebf41052c7 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Michael Ho <k...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Henry Robinson <he...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Michael Ho <k...@cloudera.com> Gerrit-Reviewer: Sailesh Mukil <sail...@cloudera.com> Gerrit-HasComments: Yes
