Tim Armstrong has posted comments on this change. Change subject: IMPALA-5867: Fix bugs parsing 2-digit year ......................................................................
Patch Set 1: (2 comments) Thanks for the explanations. I think I follow the code now. Just had a couple of minor comments. http://gerrit.cloudera.org:8080/#/c/7910/1/be/src/runtime/timestamp-parse-util.cc File be/src/runtime/timestamp-parse-util.cc: Line 370: if (d->year() < 1400 || d->year() > 9999) { > Changed to a single call to year(). It looks stupid but I don't know other Ah ok, I misunderstood the purpose of the old code The old code actually seems simpler to me, TBH, so I'm ok if you want to change back to that. http://gerrit.cloudera.org:8080/#/c/7910/2/be/src/runtime/timestamp-parse-util.cc File be/src/runtime/timestamp-parse-util.cc: Line 320: int day_offset = 0; nit: can you declare this as a static method in the class for consistency. -- To view, visit http://gerrit.cloudera.org:8080/7910 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia4f430caea88b6c33f8050a1984ee0ee32ecb0a1 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tianyi Wang <tw...@cloudera.com> Gerrit-Reviewer: Tianyi Wang <tw...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-HasComments: Yes
