John Russell has posted comments on this change. Change subject: IMPALA-2107: [DOCS] Document base64*code() functions ......................................................................
Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/7963/1/docs/shared/impala_common.xml File docs/shared/impala_common.xml: Line 802: <codeph>MAX()</codeph>, and <codeph>MIN()</codeph> than when > Are you sure about MAX and MIN? They might preserve ordering. I don't know. Done. That was a close call that it does appear to be correct. In a sample of about a dozen words and phrases, I found almost all were sorted the same way as the unencoded values, but the 'w' entries came before the 't' ones: | world | d29ybGQ= | | whirled | d2hpcmxlZA== | | whorled | d2hvcmxlZA== | | the rain in spain | dGhlIHJhaW4gaW4gc3BhaW4= | | the time has come | dGhlIHRpbWUgaGFzIGNvbWU= | PS1, Line 808: All argument values : supplied to <codeph>base64decode()</codeph> must also be a : multiple of 4 bytes in length. > I don't think this is right. The example you give below, for instance, is ' Right, the constraint (must be) is on base64decode argument, and the guarantee (is always) is on the base64encode return value. That was a finger fumble to say base64encode in both places. http://gerrit.cloudera.org:8080/#/c/7963/1/docs/topics/impala_string_functions.xml File docs/topics/impala_string_functions.xml: Line 88: <dlentry id="base64decode" rev="2.6.0 IMPALA-2107"> > This was fixed in 2.6.0, according to the ticket, not 2.9.0 Done. Changed for both base64decode and base64encode <dlentry> tags. -- To view, visit http://gerrit.cloudera.org:8080/7963 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5251e368ad36756c19a7b97e5ef6f232f616189b Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: John Russell <jruss...@cloudera.com> Gerrit-Reviewer: Greg Rahn <gr...@cloudera.com> Gerrit-Reviewer: Jim Apple <jbapple-imp...@apache.org> Gerrit-Reviewer: John Russell <jruss...@cloudera.com> Gerrit-HasComments: Yes
