Dan Hecht has posted comments on this change. Change subject: IMPALA-5912: fix crash in trunc(..., "WW") in release build ......................................................................
Patch Set 1: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/8015/1//COMMIT_MSG Commit Message: PS1, Line 23: Also remove other uses of references to temporary that were correct but : unnecessary given that the function returned a value and C++11 : return value optimisation should kick in. okay with me (if RVO is applying so no perf impact), but the const-ref-to-temporary is a pattern we use broadly especially for TimestampValue (for better or worse). -- To view, visit http://gerrit.cloudera.org:8080/8015 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic5017518188f5025daa5040ca1943581a0675726 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com> Gerrit-Reviewer: Matthew Jacobs <m...@cloudera.com> Gerrit-Reviewer: Thomas Tauber-Marshall <tmarsh...@cloudera.com> Gerrit-HasComments: Yes
