Sailesh Mukil has posted comments on this change. Change subject: IMPALA-4670: Introduces RpcMgr class ......................................................................
Patch Set 6: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/#/c/7901/6/be/src/rpc/rpc-mgr-test.cc File be/src/rpc/rpc-mgr-test.cc: PS6, Line 65: FLAGS_hostname Do we want this to be the loopback address since this is only a test? The thrift-server-test listens on the loopback address instead of the externally visible hostname, but I'm fine either way. -- To view, visit http://gerrit.cloudera.org:8080/7901 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8adb10ae375d7bf945394c38a520f12d29cf7b46 Gerrit-PatchSet: 6 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Michael Ho <k...@cloudera.com> Gerrit-Reviewer: Michael Ho <k...@cloudera.com> Gerrit-Reviewer: Sailesh Mukil <sail...@cloudera.com> Gerrit-HasComments: Yes
