Alex Behm has posted comments on this change. Change subject: IMPALA-5881: Use native allocation while building catalog updates ......................................................................
Patch Set 18: Code-Review+1 (6 comments) Dimitris, any more comments? http://gerrit.cloudera.org:8080/#/c/7955/18/fe/src/test/java/org/apache/impala/thrift/NativeByteArrayOutputStreamTest.java File fe/src/test/java/org/apache/impala/thrift/NativeByteArrayOutputStreamTest.java: Line 61: nbaos.write(b, offset, len); try catch and assert if we catch an exception or use the exceptionCaught pattern you use for the c'tor test below Line 67: // Makes sure that the memory is freed by the end of nboas.write(). Expects a write() to fail and checks that the memory is freed after the unsuccessful write(). Line 71: nbaos.write(b, offset, len); Add an assert that fails if the write succeeded. Line 95: public void nbaosTest() { NbaosTest Line 99: testAllocator = new NativeTestAllocator(); move into L96 Line 100: // Check that initial allocation failure in NBAOS c'tor remove "that" -- To view, visit http://gerrit.cloudera.org:8080/7955 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I383684effa9524734ce3c6c0fb7ed37de0e15782 Gerrit-PatchSet: 18 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Bharath Vissapragada <bhara...@cloudera.com> Gerrit-Reviewer: Alex Behm <alex.b...@cloudera.com> Gerrit-Reviewer: Bharath Vissapragada <bhara...@cloudera.com> Gerrit-Reviewer: Dimitris Tsirogiannis <dtsirogian...@cloudera.com> Gerrit-Reviewer: Mostafa Mokhtar <mmokh...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-HasComments: Yes
