Dan Hecht has posted comments on this change. Change subject: IMPALA-5417: make I/O buffer queue fixed-size ......................................................................
Patch Set 7: Code-Review+2 (2 comments) http://gerrit.cloudera.org:8080/#/c/7408/7/be/src/runtime/disk-io-mgr-scan-range.cc File be/src/runtime/disk-io-mgr-scan-range.cc: Line 47: DCHECK(reader_lock.mutex() == &reader_->lock_ && reader_lock.owns_lock()); does that belong in the scope? seems clearer to start the scope with the lock acquisition to make it clear why there's a scope. http://gerrit.cloudera.org:8080/#/c/7408/7/be/src/runtime/disk-io-mgr.h File be/src/runtime/disk-io-mgr.h: PS7, Line 801: be an I/O is that suppose to say buffer? Or does it mean I/O operation? -- To view, visit http://gerrit.cloudera.org:8080/7408 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: If7cc3f7199f5320db00b7face97a96cdadb6f83f Gerrit-PatchSet: 7 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com> Gerrit-Reviewer: Matthew Jacobs <m...@cloudera.com> Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Michael Ho <k...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-HasComments: Yes
