Dan Hecht has posted comments on this change. Change subject: IMPALA-3877: support unpatched LLVM ......................................................................
Patch Set 2: Code-Review+1 (1 comment) Nice to drop that patch. Please have Michael look too when he's back. http://gerrit.cloudera.org:8080/#/c/7973/2/be/src/codegen/codegen-util.h File be/src/codegen/codegen-util.h: PS2, Line 34: when calling functions from a linked module because the LLVM linker likes to : /// merge struct types in unpredictable ways during linking. that's gonna be a bit hard for people to figure out, I think. is there a JIRA worth referencing with more details? -- To view, visit http://gerrit.cloudera.org:8080/7973 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3dfbe44ed8a1464b9b0991fd54e72b194ad6155d Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com> Gerrit-HasComments: Yes
