Tim Armstrong has posted comments on this change. Change subject: IMPALA-5941: Fix Metastore schema creation in create-test-configuration.sh ......................................................................
Patch Set 1: Code-Review+2 (1 comment) Looks good. Will wait to see if you agree with my suggestion before merging. http://gerrit.cloudera.org:8080/#/c/8081/1/bin/create-test-configuration.sh File bin/create-test-configuration.sh: Line 99: -f ${HIVE_HOME}/scripts/metastore/upgrade/postgres/hive-schema-1.1.0.postgres.sql Very minor comment: it might be simpler to use a relative path here and avoid repeating the directory name. -- To view, visit http://gerrit.cloudera.org:8080/8081 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic312df4597c7d211d4ecd551d572f751aea0cd24 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-HasComments: Yes
