Tianyi Wang has posted comments on this change. Change subject: IMPALA-5932: Improve transitive closure computation performance in FE ......................................................................
Patch Set 2: (5 comments) http://gerrit.cloudera.org:8080/#/c/8098/1//COMMIT_MSG Commit Message: Line 7: IMPALA-5932: Improve transitive closure computation performance in FE > Shrink to fit Done Line 9: This patch implements the Floyd-Warshall algorithm for the transitive > the Floyd-Warshall algorithm Done Line 10: closure computation for the value transfer graph, replacing the existing > closure computation for the value transfer graph Done http://gerrit.cloudera.org:8080/#/c/8098/1/fe/src/main/java/org/apache/impala/analysis/Analyzer.java File fe/src/main/java/org/apache/impala/analysis/Analyzer.java: Line 2703: valueTransfer_[p[i]][p[k]] |= valueTransfer_[p[i]][p[j]] && > Comment that this optimization works because our graphs are typically spars Done http://gerrit.cloudera.org:8080/#/c/8098/2/fe/src/main/java/org/apache/impala/analysis/Analyzer.java File fe/src/main/java/org/apache/impala/analysis/Analyzer.java: Line 2698 Removed this comment since the graph here is not a DAG: select * from (select * from tb0) v0 left join (select * from tb0) v1 on v0.c=v1.c left join (select * from tb0) v2 on v1.c=v2.c left join (select * from tb0) v3 on v2.c=v3.c where v0.c=v3.c; -- To view, visit http://gerrit.cloudera.org:8080/8098 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idb00e3c1f904e60ae25567a52b4bf0809a84c6b3 Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tianyi Wang <tw...@cloudera.com> Gerrit-Reviewer: Alex Behm <alex.b...@cloudera.com> Gerrit-Reviewer: Tianyi Wang <tw...@cloudera.com> Gerrit-HasComments: Yes
