Pranay Singh has abandoned this change. ( http://gerrit.cloudera.org:8080/7725 )
Change subject: IMPALA-1649 Pass precision to Print TCounterType::DOUBLE_VALUE ...................................................................... Abandoned After talking to Tim and Joe, it appears that TUnit::DOUBLE_VALUE is needed and cannot be removed. The use of TUnit::DOUBLE_VALUE can be seen in the function RuntimeProfile::PrintChildCounters(), which calls PrettyPrinter::Print() for printing different TUnit types. We can't differentiate between the counters that need to be displayed with a decimal precision of FIXED_PRECISION from the other TUnit::UNIT types, if we remove TUnit::DOUBLE_VALUE . So we do need TUnit::DOUBLE_VALUE to have counters that need to be displayed as a floating point values with FIXED_PRECISION. -- To view, visit http://gerrit.cloudera.org:8080/7725 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: abandon Gerrit-Change-Id: Icc63d8a59bdf175341097df143798fb1a957d93f Gerrit-Change-Number: 7725 Gerrit-PatchSet: 2 Gerrit-Owner: Pranay Singh Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Pranay Singh
