Tim Wood has posted comments on this change. ( http://gerrit.cloudera.org:8080/8102 )
Change subject: IMPALA-5376: Implement all TPCDS test cases or alternates for Impala. ...................................................................... Patch Set 6: (4 comments) Updates to PS 5. http://gerrit.cloudera.org:8080/#/c/8102/5//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/8102/5//COMMIT_MSG@11 PS5, Line 11: $IMPALA_HOME/buildall.sh -te > Nit: buildall.sh is in the root of Impala, not bin/ Done http://gerrit.cloudera.org:8080/#/c/8102/5//COMMIT_MSG@12 PS5, Line 12: This commit continues previous work on IMPALA-5376 in the ASF Impala repo : and the Cloudera Gerrit service. > Not sure this is needed. You reference IMPALA-5376 in the commit title appr I think it's important to mention the previous work, but I'm removing the hard identifiers. http://gerrit.cloudera.org:8080/#/c/8102/5//COMMIT_MSG@15 PS5, Line 15: ery tests in the > Can you explain in the commit message how you made the decision to have pas Done http://gerrit.cloudera.org:8080/#/c/8102/5//COMMIT_MSG@17 PS5, Line 17: : > Can you file a follow on Jira for the stress test (project: IMPALA; compone Filed IMPALA-5970. -- To view, visit http://gerrit.cloudera.org:8080/8102 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6e284888600a7a69d1f23fcb7dac21cbb13b7d66 Gerrit-Change-Number: 8102 Gerrit-PatchSet: 6 Gerrit-Owner: Tim Wood <tw...@cloudera.com> Gerrit-Reviewer: Alex Behm <alex.b...@cloudera.com> Gerrit-Reviewer: David Knupp <dkn...@cloudera.com> Gerrit-Reviewer: Matthew Mulder <mmul...@cloudera.com> Gerrit-Reviewer: Michael Brown <mi...@cloudera.com> Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Mostafa Mokhtar <mmokh...@cloudera.com> Gerrit-Reviewer: Tim Wood <tw...@cloudera.com> Gerrit-Comment-Date: Fri, 22 Sep 2017 21:23:26 +0000 Gerrit-HasComments: Yes
