Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/8100 )
Change subject: IMPALA-5940: Avoid log spew by using Status::Expected. ...................................................................... Patch Set 3: (5 comments) http://gerrit.cloudera.org:8080/#/c/8100/3/be/src/exec/hdfs-avro-scanner.cc File be/src/exec/hdfs-avro-scanner.cc: http://gerrit.cloudera.org:8080/#/c/8100/3/be/src/exec/hdfs-avro-scanner.cc@972 PS3, Line 972: return Status::Expected(Substitute( Michael/Tim - these will show up in the runtime profile still, right? so okay to avoid logging them, right? http://gerrit.cloudera.org:8080/#/c/8100/3/be/src/runtime/client-cache.h File be/src/runtime/client-cache.h: http://gerrit.cloudera.org:8080/#/c/8100/3/be/src/runtime/client-cache.h@243 PS3, Line 243: string err = strings::Substitute("Client $0 timed-out during recv call.", TNetworkAddressToString(address_)); long line http://gerrit.cloudera.org:8080/#/c/8100/3/be/src/runtime/client-cache.h@246 PS3, Line 246: return Status::Expected(ErrorMsg(TErrorCode::RPC_RECV_TIMEOUT, err)); Michael/Sailesh - are you guys okay with eliminating this backtrace, or have we found it useful for debugging in the field? http://gerrit.cloudera.org:8080/#/c/8100/3/be/src/runtime/client-cache.h@281 PS3, Line 281: return Status::Expected(ErrorMsg(TErrorCode::RPC_RECV_TIMEOUT, err)); same set of comment/question http://gerrit.cloudera.org:8080/#/c/8100/3/be/src/runtime/tuple.cc File be/src/runtime/tuple.cc: http://gerrit.cloudera.org:8080/#/c/8100/3/be/src/runtime/tuple.cc@309 PS3, Line 309: stringstream ss; : ss << "Could not codegen CodegenMaterializeExprs: " << status.GetDetail(); okay to ignore, but could clean that up with Substitute() -- To view, visit http://gerrit.cloudera.org:8080/8100 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I38088482377a1c3e794a9c8178ef83f29957a330 Gerrit-Change-Number: 8100 Gerrit-PatchSet: 3 Gerrit-Owner: Philip Zeyliger <phi...@cloudera.com> Gerrit-Reviewer: Alex Behm <alex.b...@cloudera.com> Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com> Gerrit-Reviewer: Mostafa Mokhtar <mmokh...@cloudera.com> Gerrit-Reviewer: Philip Zeyliger <phi...@cloudera.com> Gerrit-Comment-Date: Fri, 29 Sep 2017 00:07:02 +0000 Gerrit-HasComments: Yes
