Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/8168 )
Change subject: IMPALA-4951: Fix database visibility for user with only column privilege ...................................................................... Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/8168/2/testdata/workloads/functional-query/queries/QueryTest/grant_revoke.test File testdata/workloads/functional-query/queries/QueryTest/grant_revoke.test: http://gerrit.cloudera.org:8080/#/c/8168/2/testdata/workloads/functional-query/queries/QueryTest/grant_revoke.test@744 PS2, Line 744: revoke role grant_revoke_test_ROOT from group root > Is this needed for your test? Done http://gerrit.cloudera.org:8080/#/c/8168/2/testdata/workloads/functional-query/queries/QueryTest/grant_revoke.test@750 PS2, Line 750: ---- QUERY : show current roles : ---- RESULTS: VERIFY_IS_SUBSET : 'grant_revoke_test_ALL_SERVER' : ---- TYPES : STRING : ==== > No need for that. Let's remove to make the test a bit smaller. Done http://gerrit.cloudera.org:8080/#/c/8168/2/testdata/workloads/functional-query/queries/QueryTest/grant_revoke.test@808 PS2, Line 808: # IMPALA-4951: make sure database is visible to a user having only column level access : # to a table in the database > I think it may be best to move this comment at the beginning of your change Done -- To view, visit http://gerrit.cloudera.org:8080/8168 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id77904876729c0223fd6ace2d5e7199bd700a33a Gerrit-Change-Number: 8168 Gerrit-PatchSet: 2 Gerrit-Owner: Bikramjeet Vig <bikramjeet....@cloudera.com> Gerrit-Reviewer: Bikramjeet Vig <bikramjeet....@cloudera.com> Gerrit-Reviewer: Dimitris Tsirogiannis <dtsirogian...@cloudera.com> Gerrit-Comment-Date: Fri, 29 Sep 2017 17:20:49 +0000 Gerrit-HasComments: Yes
