Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/8148 )
Change subject: IMPALA-4252: Move runtime filters to ScanNode ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/8148/1/be/src/exec/scan-node.cc File be/src/exec/scan-node.cc: http://gerrit.cloudera.org:8080/#/c/8148/1/be/src/exec/scan-node.cc@79 PS1, Line 79: // TODO: Move this to Prepare() > Not sure, it was left by Michael (I'll ping him about it) in the review "Di Yes, I should have probably left more details. The original plan for the MT work is to have one filter bank shared across all fragment instances. The single PlanNode instance of ScanNode will then register the filter during the PlanNode tree creation. Then, during ScanNode::Prepare() for an ExecTree instance (inside a fragment instance), we will just look up the filter in the shared filter bank and fill in the filter_ctxs_. -- To view, visit http://gerrit.cloudera.org:8080/8148 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I17bdc869046dc2cd837d02f333441fa6324ff086 Gerrit-Change-Number: 8148 Gerrit-PatchSet: 1 Gerrit-Owner: Thomas Tauber-Marshall <tmarsh...@cloudera.com> Gerrit-Reviewer: Michael Ho <k...@cloudera.com> Gerrit-Reviewer: Thomas Tauber-Marshall <tmarsh...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Mon, 02 Oct 2017 06:44:47 +0000 Gerrit-HasComments: Yes
