John Russell has posted comments on this change. ( http://gerrit.cloudera.org:8080/8189 )
Change subject: IMPALA-5529: [DOCS] New trunc() signatures ...................................................................... Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/8189/3/docs/topics/impala_datetime_functions.xml File docs/topics/impala_datetime_functions.xml: http://gerrit.cloudera.org:8080/#/c/8189/3/docs/topics/impala_datetime_functions.xml@2174 PS3, Line 2174: <codeph>trunc(numeric n)</codeph>, : <codeph>trunc(decimal d, integer scale)</codeph> Why don't we add a pointer from dtrunc / truncate to here. Those are covered under "Mathematical Functions". Actually it feels strange to have trunc() doing double duty as a date/time functiona and a math function, both listed on the Date/Time Functions page. But I don't want to make entries labelled "trunc()" on both pages. Maybe I can reuse some of the text and examples for numeric trunc() under truncate() on the math functions page. -- To view, visit http://gerrit.cloudera.org:8080/8189 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ice4753dee4f7b8e09c35508a9cad1e36f4ab2826 Gerrit-Change-Number: 8189 Gerrit-PatchSet: 3 Gerrit-Owner: John Russell <jruss...@cloudera.com> Gerrit-Reviewer: Alex Behm <alex.b...@cloudera.com> Gerrit-Reviewer: Greg Rahn <gr...@cloudera.com> Gerrit-Reviewer: John Russell <jruss...@cloudera.com> Gerrit-Reviewer: Kim Jin Chul <jinc...@gmail.com> Gerrit-Comment-Date: Mon, 02 Oct 2017 17:15:21 +0000 Gerrit-HasComments: Yes
