Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/7954 )
Change subject: IMPALA-5664: Unix time to timestamp conversions may crash Impala ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/7954/2/be/src/runtime/timestamp-value.h File be/src/runtime/timestamp-value.h: http://gerrit.cloudera.org:8080/#/c/7954/2/be/src/runtime/timestamp-value.h@86 PS2, Line 86: } > But what we need is to log to the warning log, like the code in timestamp-f I have added some logging to warning. The string -> timestamp cast is not related to this issue, but I think it is very useful to warn the user about the invalid formatting. I have left the logging in TimestampValue::Validate, maybe it will be useful for postmortem analysis one day. http://gerrit.cloudera.org:8080/#/c/7954/8/be/src/runtime/timestamp-value.cc File be/src/runtime/timestamp-value.cc: http://gerrit.cloudera.org:8080/#/c/7954/8/be/src/runtime/timestamp-value.cc@116 PS8, Line 116: /// The time zone of the resulting ptime is local time. This is called by > nit: for style consistency combine lines 115 & 116. Done -- To view, visit http://gerrit.cloudera.org:8080/7954 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I77b2f6284d3a597f57e61c17a67c959eff9e38ff Gerrit-Change-Number: 7954 Gerrit-PatchSet: 2 Gerrit-Owner: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com> Gerrit-Reviewer: Lars Volker <l...@cloudera.com> Gerrit-Comment-Date: Mon, 02 Oct 2017 18:00:10 +0000 Gerrit-HasComments: Yes
