Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/8202 )
Change subject: IMPALA-4704: Disallow client connections to imapalad until catalog is received. ...................................................................... Patch Set 1: (2 comments) It does seem like picking a reasonable timeout here is not possible. Additionally, given that the current behavior is that all queries will fail before isReady(), waiting indefinitely for isReady() seems okay. http://gerrit.cloudera.org:8080/#/c/8202/1/be/src/service/impala-server.cc File be/src/service/impala-server.cc: http://gerrit.cloudera.org:8080/#/c/8202/1/be/src/service/impala-server.cc@2043 PS1, Line 2043: FLAGS_is_coordinator the relationship between this code and the HS2/Beeswax servers would be clearer if this were: if (hs2_server_.get() != NULL || beeswax_server_.get() != NULL) or if we just call WaitForCatalog() on both branches. http://gerrit.cloudera.org:8080/#/c/8202/1/fe/src/main/java/org/apache/impala/service/Frontend.java File fe/src/main/java/org/apache/impala/service/Frontend.java: http://gerrit.cloudera.org:8080/#/c/8202/1/fe/src/main/java/org/apache/impala/service/Frontend.java@905 PS1, Line 905: if (!impaladCatalog_.get().isReady()) { perhaps this should be a Preconditions check, if our intention is to prevent this from being callable before isReady() returns true. -- To view, visit http://gerrit.cloudera.org:8080/8202 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I52b881cba18a7e4533e21a78751c2e35c3d4c8a6 Gerrit-Change-Number: 8202 Gerrit-PatchSet: 1 Gerrit-Owner: Vuk Ercegovac <vercego...@cloudera.com> Gerrit-Reviewer: Balazs Jeszenszky <jes...@gmail.com> Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com> Gerrit-Reviewer: Philip Zeyliger <phi...@cloudera.com> Gerrit-Reviewer: Vuk Ercegovac <vercego...@cloudera.com> Gerrit-Comment-Date: Wed, 04 Oct 2017 17:39:33 +0000 Gerrit-HasComments: Yes
