Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/8145 )
Change subject: IMPALA-5988: optimise MemPool::TryAllocate() ...................................................................... Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/8145/3/be/src/runtime/mem-pool.h File be/src/runtime/mem-pool.h: http://gerrit.cloudera.org:8080/#/c/8145/3/be/src/runtime/mem-pool.h@122 PS3, Line 122: uint8_t* TryAllocateUnaligned(int64_t size) noexcept { > The default has been 8 byte aligned for as long as I'm aware. Thanks, works for me. We can still reconsider the default later if necessary. We do make many small allocations in other places like CollectionValueBuilder (for collections with small tuples). -- To view, visit http://gerrit.cloudera.org:8080/8145 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I088012084fe535a67a3cd1103ced5a02027f961a Gerrit-Change-Number: 8145 Gerrit-PatchSet: 3 Gerrit-Owner: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Alex Behm <alex.b...@cloudera.com> Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Wed, 04 Oct 2017 21:15:11 +0000 Gerrit-HasComments: Yes