Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/8216 )
Change subject: IMPALA-6011: Remove use of Guava Hasher. ...................................................................... Patch Set 1: (4 comments) http://gerrit.cloudera.org:8080/#/c/8216/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/8216/1//COMMIT_MSG@15 PS1, Line 15: in the shell. I verified that the new code is executed. > It looks like lineage.test verifies the exact value of some query hashes to lineage.test is a planner test. It succeeds because we don't compare the query hash, see ColumnLineageGraph.equals(). http://gerrit.cloudera.org:8080/#/c/8216/1/fe/src/main/java/org/apache/impala/analysis/ColumnLineageGraph.java File fe/src/main/java/org/apache/impala/analysis/ColumnLineageGraph.java: http://gerrit.cloudera.org:8080/#/c/8216/1/fe/src/main/java/org/apache/impala/analysis/ColumnLineageGraph.java@596 PS1, Line 596: return "Query hash failed"; > Seems like this should be a precondition or throw a runtime error or simila Done http://gerrit.cloudera.org:8080/#/c/8216/1/fe/src/main/java/org/apache/impala/analysis/ColumnLineageGraph.java@601 PS1, Line 601: // String conversion code taken from Guava's HashCode.toString(). > Seems like the string conversion code should be a utility function. Alterna I bet we are pulling in many versions of Apache commons as well. The API may be more stable, but no idea about the behavior. I prefer this version which seems most predictable. http://gerrit.cloudera.org:8080/#/c/8216/1/fe/src/main/java/org/apache/impala/analysis/ColumnLineageGraph.java@602 PS1, Line 602: final char[] hexDigits = "0123456789abcdef".toCharArray(); > nit: I would have expected this to be a class constant Done. -- To view, visit http://gerrit.cloudera.org:8080/8216 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I04b8888b436eb93a86b8db24b2a97f14047f828b Gerrit-Change-Number: 8216 Gerrit-PatchSet: 1 Gerrit-Owner: Alex Behm <alex.b...@cloudera.com> Gerrit-Reviewer: Alex Behm <alex.b...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Philip Zeyliger <phi...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Thu, 05 Oct 2017 17:36:34 +0000 Gerrit-HasComments: Yes
