Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/7901 )
Change subject: IMPALA-4670: Introduces RpcMgr class ...................................................................... Patch Set 10: Code-Review+2 Carry +2. PS 10 fixed up a CMake target name issue which tricked ninja into thinking there is a circular dependency when there is none. Also clarified a comment in rpc-mgr.h to address Dan's point. -- To view, visit http://gerrit.cloudera.org:8080/7901 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8adb10ae375d7bf945394c38a520f12d29cf7b46 Gerrit-Change-Number: 7901 Gerrit-PatchSet: 10 Gerrit-Owner: Michael Ho <k...@cloudera.com> Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Ho <k...@cloudera.com> Gerrit-Reviewer: Sailesh Mukil <sail...@cloudera.com> Gerrit-Comment-Date: Fri, 06 Oct 2017 02:54:47 +0000 Gerrit-HasComments: No