Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/7999 )
Change subject: [DOCS] Tighten up advice about first COMPUTE INCREMENTAL STATS ...................................................................... Patch Set 2: (8 comments) http://gerrit.cloudera.org:8080/#/c/7999/2/docs/shared/impala_common.xml File docs/shared/impala_common.xml: http://gerrit.cloudera.org:8080/#/c/7999/2/docs/shared/impala_common.xml@1228 PS2, Line 1228: DROP STATS</codeph> and : <codeph>DROP INCREMENTAL STATS</codeph>) are these drops required? http://gerrit.cloudera.org:8080/#/c/7999/2/docs/shared/impala_common.xml@1243 PS2, Line 1243: be cached on every <cmdname>impalad</cmdname> host. If this metadata for a table exceeds more specifically, impalads that are also coordinators? http://gerrit.cloudera.org:8080/#/c/7999/2/docs/shared/impala_common.xml@1243 PS2, Line 1243: metadata for a table exceeds : 2 GB is there a diagnostic page that we can point to here that explains how to find the size of metadata (either via a sql query or a monitoring webpage)? http://gerrit.cloudera.org:8080/#/c/7999/2/docs/shared/impala_common.xml@1247 PS2, Line 1247: does not affect does that mean lack of stats has not affect on optimization or something else? http://gerrit.cloudera.org:8080/#/c/7999/2/docs/topics/impala_partitioning.xml File docs/topics/impala_partitioning.xml: http://gerrit.cloudera.org:8080/#/c/7999/2/docs/topics/impala_partitioning.xml@611 PS2, Line 611: frequently remove http://gerrit.cloudera.org:8080/#/c/7999/2/docs/topics/impala_partitioning.xml@623 PS2, Line 623: is a shortcut I don't know what "shortcut" means here. I'd remove it. http://gerrit.cloudera.org:8080/#/c/7999/2/docs/topics/impala_perf_stats.xml File docs/topics/impala_perf_stats.xml: http://gerrit.cloudera.org:8080/#/c/7999/2/docs/topics/impala_perf_stats.xml@361 PS2, Line 361: That situation is where you switch I'd reword this part ("That situation is where ..."). Suggestion: >From <keyword keyref="impala21_full"/> and higher, use the new feature to >compute statistics incrementally on just the partitions that changed. See ... http://gerrit.cloudera.org:8080/#/c/7999/2/docs/topics/impala_perf_stats.xml@412 PS2, Line 412: >COMPUTE INCREMENTAL STAT docs in impala_common mention "drop stats" before making a switch. that's not mentioned here. what is the required/suggested usage? perhaps call this out as a "switch" and link to why the user should avoid this. -- To view, visit http://gerrit.cloudera.org:8080/7999 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia53a6518ce5541e5c9a2cd896856ce042a599b03 Gerrit-Change-Number: 7999 Gerrit-PatchSet: 2 Gerrit-Owner: John Russell <jruss...@cloudera.com> Gerrit-Reviewer: Alex Behm <alex.b...@cloudera.com> Gerrit-Reviewer: Greg Rahn <gr...@cloudera.com> Gerrit-Reviewer: John Russell <jruss...@cloudera.com> Gerrit-Reviewer: Mostafa Mokhtar <mmokh...@cloudera.com> Gerrit-Reviewer: Silvius Rus <s...@cloudera.com> Gerrit-Reviewer: Vuk Ercegovac <vercego...@cloudera.com> Gerrit-Comment-Date: Fri, 06 Oct 2017 17:11:28 +0000 Gerrit-HasComments: Yes
