Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8230 )
Change subject: Allow the SASL protocol service name to be configurable ...................................................................... Allow the SASL protocol service name to be configurable Previously the SASL service name was always set to a constant "kudu" which was tracked by kSaslProtoName in rpc/constants.h. However, for applications that use the KRPC library that would prefer to do their own SASL initialization, they would requre to set their own SASL service name to be passed into sasl_server_new()/sasl_client_new(). This patch allows for this configuration by adding a configurable parameter to the MessengerBuilder which is ultimately passed down to the negotiation layer. Change-Id: I9e30fe4461893b67527333259579e2304b19af1e Reviewed-on: http://gerrit.cloudera.org:8080/8218 Reviewed-by: Dan Burkert <danburk...@apache.org> Tested-by: Dan Burkert <danburk...@apache.org> Reviewed-on: http://gerrit.cloudera.org:8080/8230 Reviewed-by: Sailesh Mukil <sail...@cloudera.com> Tested-by: Impala Public Jenkins --- M be/src/kudu/rpc/client_negotiation.cc M be/src/kudu/rpc/client_negotiation.h M be/src/kudu/rpc/constants.cc M be/src/kudu/rpc/constants.h M be/src/kudu/rpc/messenger.cc M be/src/kudu/rpc/messenger.h M be/src/kudu/rpc/negotiation-test.cc M be/src/kudu/rpc/negotiation.cc M be/src/kudu/rpc/server_negotiation.cc M be/src/kudu/rpc/server_negotiation.h 10 files changed, 59 insertions(+), 28 deletions(-) Approvals: Sailesh Mukil: Looks good to me, approved Impala Public Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/8230 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I9e30fe4461893b67527333259579e2304b19af1e Gerrit-Change-Number: 8230 Gerrit-PatchSet: 4 Gerrit-Owner: Sailesh Mukil <sail...@cloudera.com> Gerrit-Reviewer: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Ho <k...@cloudera.com> Gerrit-Reviewer: Sailesh Mukil <sail...@cloudera.com>
