Zoram Thanga has posted comments on this change. (
http://gerrit.cloudera.org:8080/8305 )
Change subject: IMPALA-5599: Clean up references to TimestampValue in be/src.
......................................................................
Patch Set 2:
> (1 comment)
>
> Code change looks good.
>
> How did you test it? Please add a Testing section to commit message
> indicating that. Please at least manually inspect each affected
> field by e.g. looking at the profile.
Thanks for the suggestion to look at the profiles. Here's an example, and it
looks fine to me:
Query (id=394caf0e5f233559:8d02422c00000000):
DEBUG MODE WARNING: Query profile created while running a DEBUG build of
Impala. Use RELEASE builds to measure query performance.
Summary:
Session ID: 864fbccb3e7bee09:7fa78fb245fa3688
Session Type: BEESWAX
Start Time: 2017-10-18 20:21:59.972644
End Time: 2017-10-18 20:22:00.097281
Query Type: N/A
Query State: EXCEPTION
Query Status: AnalysisException: Could not resolve table reference:
'tpch_avro.lineitem'
Impala Version: impalad version 2.11.0-SNAPSHOT DEBUG (build
979c3dfd6fc40dbfb413cf45a9560f81495d1f5a)
User: zoram
Connected User: zoram
Delegated User:
Network Address: <redacted>
Default Db: default
Sql Statement: select l_orderkey from tpch_avro.lineitem having
count(l_orderkey) > 1
Coordinator: impala-1:22000
Query Timeline: 124.796ms
- Query submitted: 45.687us (45.687us)
- Unregister query: 124.627ms (124.582ms)
--
To view, visit http://gerrit.cloudera.org:8080/8305
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I642a1d713597826bb7c15cd2ecb6638cb813a02c
Gerrit-Change-Number: 8305
Gerrit-PatchSet: 2
Gerrit-Owner: Zoram Thanga <zo...@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com>
Gerrit-Reviewer: Michael Ho <k...@cloudera.com>
Gerrit-Reviewer: Zoram Thanga <zo...@cloudera.com>
Gerrit-Comment-Date: Thu, 19 Oct 2017 03:32:49 +0000
Gerrit-HasComments: No
