Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/8051 )
Change subject: IMPALA-5668: Fix cast(X as timestamp) for negative subsecond Decimals ...................................................................... Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c/8051/4/be/src/exprs/decimal-operators-ir.cc File be/src/exprs/decimal-operators-ir.cc: http://gerrit.cloudera.org:8080/#/c/8051/4/be/src/exprs/decimal-operators-ir.cc@604 PS4, Line 604: DCHECK(nanoseconds >= numeric_limits<int32_t>::min() > We generally prefer DCHECK_GE() and DCHECK_LE() so that the out-of-range va DCHECK_GL/E() lead to compile error, because int128_t cannot be handled by operator <<. ( see https://stackoverflow.com/questions/25114597/how-to-print-int128-in-g ). It is possible to write such an operator, but I am not sure that it is a good idea, unless it is really necessary. http://gerrit.cloudera.org:8080/#/c/8051/4/be/src/exprs/decimal-operators-ir.cc@622 PS4, Line 622: FromUnixTimeNanos > Can you add a note to this function's comment that it's expected to work fo Done -- To view, visit http://gerrit.cloudera.org:8080/8051 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8216f4c0f100c1bd68891cd6048236bfe4c205f0 Gerrit-Change-Number: 8051 Gerrit-PatchSet: 4 Gerrit-Owner: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Lars Volker <l...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Fri, 20 Oct 2017 18:38:12 +0000 Gerrit-HasComments: Yes
