Dimitris Tsirogiannis has posted comments on this change. ( http://gerrit.cloudera.org:8080/8202 )
Change subject: IMPALA-4704: Turns on client connections when local catalog initialized. ...................................................................... Patch Set 11: Code-Review+1 (4 comments) You may want to ask someone from BE and QE to sing off. http://gerrit.cloudera.org:8080/#/c/8202/11/be/src/service/impala-server.cc File be/src/service/impala-server.cc: http://gerrit.cloudera.org:8080/#/c/8202/11/be/src/service/impala-server.cc@1979 PS11, Line 1979: // Wait for the frontend catalog to be ready prior to opening client ports. nit: Maybe expand this comment to mention that this call will block indefinitely in the case when the first catalog update never arrives for some reason. http://gerrit.cloudera.org:8080/#/c/8202/11/bin/start-impala-cluster.py File bin/start-impala-cluster.py: http://gerrit.cloudera.org:8080/#/c/8202/11/bin/start-impala-cluster.py@82 PS11, Line 82: action="store_true", : help=SUPPRESS_HELP) nit: merge these two and save a line :) http://gerrit.cloudera.org:8080/#/c/8202/11/bin/start-impala-cluster.py@304 PS11, Line 304: wait_for_client I think this should be named wait_for_catalog since that is the high level operation we're interested in. http://gerrit.cloudera.org:8080/#/c/8202/11/tests/common/custom_cluster_test_suite.py File tests/common/custom_cluster_test_suite.py: http://gerrit.cloudera.org:8080/#/c/8202/11/tests/common/custom_cluster_test_suite.py@127 PS11, Line 127: if disable_catalog: : cmd.append("--disable_catalog") nit: single line -- To view, visit http://gerrit.cloudera.org:8080/8202 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I52b881cba18a7e4533e21a78751c2e35c3d4c8a6 Gerrit-Change-Number: 8202 Gerrit-PatchSet: 11 Gerrit-Owner: Vuk Ercegovac <vercego...@cloudera.com> Gerrit-Reviewer: Balazs Jeszenszky <jes...@gmail.com> Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com> Gerrit-Reviewer: Dimitris Tsirogiannis <dtsirogian...@cloudera.com> Gerrit-Reviewer: Philip Zeyliger <phi...@cloudera.com> Gerrit-Reviewer: Vuk Ercegovac <vercego...@cloudera.com> Gerrit-Comment-Date: Mon, 23 Oct 2017 18:43:02 +0000 Gerrit-HasComments: Yes
